Virtual Resource filters #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigkevmcd
reviewed
Aug 15, 2024
ericpromislow
requested changes
Aug 16, 2024
moio
previously approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Hey Michael, thanks for the contribution here. It's just small things and little questions from my part. 👍
I tested the current state of the PR manually on a 2.10 Rancher build and I was able to sort/filter/paginate by id and metadata.state.name.
If you want to go the extra mile I'd appreciate a test in rancher/rancher#46015, but this is completely optional.
go.mod
Outdated
| @@ -123,3 +122,5 @@ require ( | |||
| sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect | |||
| sigs.k8s.io/yaml v1.3.0 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/rancher/lasso => github.com/mbolotsuse/lasso v0.0.0-20240813171623-1292d08e0849 | |||
There was a problem hiding this comment.
Reminder: please remove and re-run go mod tidy before merging.
MbolotSuse
force-pushed
the
virtual-filter
branch
from
083c1fc to
1392960
Compare
moio
previously approved these changes
Aug 28, 2024
MbolotSuse
force-pushed
the
virtual-filter
branch
from
8763123 to
0cfc585
Compare
MbolotSuse
force-pushed
the
virtual-filter
branch
from
0cfc585 to
1149920
Compare
Adds logic which adds virtual fields resources. This allows these fields to be sorted/filtered on when the SQL cache is enabled. Id and metadata.state.name were added as the first two fields.
ericpromislow
approved these changes
Aug 28, 2024
moio
approved these changes
Aug 29, 2024
bigkevmcd
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to rancher/rancher#46330. Requires rancher/lasso#79.
Overview
This provides some basic virtual resource fields. There's a new
virtualpackage that defines a few items including the common fields from the issue and the type for a chainable transform function.